ENH: add explicit overflow guard for large nanosecond timedeltas #63808
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwas-droid
force-pushed
the
fix-timedelta-overflow
branch
from
01241e6 to
b6fa495
Compare
vishwas-droid
commented
Jan 22, 2026
Member
|
Thanks for the PR! Do you have an example where this currently does not give a nice OutOfBounds error? |
Author
|
@jorisvandenbossche Thanks for checking. |
vishwas-droid
changed the title
Author
|
cc @jorisvandenbossche @mroeschke — just a small ping on this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that constructing a Timedelta from very large integer values in nanoseconds could overflow at the C boundary. Depending on where the overflow occurred, this could result in inconsistent low-level errors instead of a clear OutOfBoundsTimedelta.
To fix this, I added an early overflow check when handling scalar nanosecond values, so that OutOfBoundsTimedelta is raised deterministically before any unsafe casting occurs. A regression test is included to ensure this behavior is preserved going forward.